chore: Upgrade brod dependency to v4 #144
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't mind to brod updating. For example, on MacOS it could be done by running |
|
Thanks for the response. Removing the system-dependent dependency would be a big improvement. We build multi-arch Docker images and use the same source on both macOS and Linux containers, so the architecture mismatch prevents us from sharing the same compilation binaries. It's not a problem with Kaffe library per-se but as the new version of Brod just remove this sub dependency it's a good way of removing the side effect of having snappyer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to compile kaffe throws the following error
using erlang 27 and elixir 1.17.2
The problem is related a sub dependency of Brod library. This sub dependency was removed in Brod 4.0